Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(sdk): use appc.version to sort releases to ensure correct ordering #479

Merged
merged 2 commits into from May 17, 2021
Merged

fix(sdk): use appc.version to sort releases to ensure correct ordering #479

merged 2 commits into from May 17, 2021

Conversation

ewanharris
Copy link
Contributor

Fixes TIMOB-28449

Note, this PR does not add this ordering to the branch listings as it's probably a little more involved as those are not even near valid versions

@build
Copy link

build commented May 17, 2021 •
edited

Warnings
⚠️

lib/commands/sdk.js#L1178 - lib/commands/sdk.js line 1178 – '_key' is assigned a value but never used. (no-unused-vars)
Messages
📖 🎉 - congrats on your new release
📖

✅ All tests are passing
Nice one! All 124 tests are passing.

Generated by 🚫 dangerJS against a5fda6e

cb1kenobi
cb1kenobi approved these changes May 17, 2021
View reviewed changes
Copy link
Contributor

@cb1kenobi cb1kenobi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

APPROVED!

@cb1kenobi cb1kenobi merged commit 40eb044 into tidev:master May 17, 2021
@ewanharris ewanharris deleted the TIMOB-28449 branch May 17, 2021 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cb1kenobi cb1kenobi cb1kenobi approved these changes

@sgtcoolguy sgtcoolguy Awaiting requested review from sgtcoolguy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ewanharris @build @cb1kenobi