Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(setup/check): remove no longer relevant checks #500

Merged
merged 1 commit into from Oct 20, 2021
Merged

refactor(setup/check): remove no longer relevant checks #500

merged 1 commit into from Oct 20, 2021

Conversation

ewanharris
Copy link
Contributor

Part of TIMOB-28519

Related to tidev/node-titanium-sdk/pull/467

@build
Copy link

build commented Aug 13, 2021

Warnings
⚠️

lib/commands/setup.js#L1241 - lib/commands/setup.js line 1241 – 'url.parse' was deprecated since v11.0.0. Use 'url.URL' constructor instead. (node/no-deprecated-api)
Messages
📖

✅ All tests are passing
Nice one! All 124 tests are passing.

Generated by 🚫 dangerJS against 74a93da

jquick-axway
jquick-axway approved these changes Aug 24, 2021
View reviewed changes
Copy link

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ewanharris ewanharris merged commit a2b27cd into tidev:master Oct 20, 2021
@ewanharris ewanharris deleted the TIMOB-28519 branch October 20, 2021 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jquick-axway jquick-axway jquick-axway approved these changes

@garymathews garymathews Awaiting requested review from garymathews

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ewanharris @build @jquick-axway