[6_1_x][TIMOB-24799] Fix issue where theme was being set as its parent #9135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewanharris
changed the title
|
FR Passed. Setting theme as in the tiapp.xml does not inherit itself & no error seen. Ran the attached app in the ticket with the fix & no error/crash was seen. |
|
OOPS, merged accidentally before the CR. @garymathews or @cb1kenobi, can you please do a quick CR. Thanks. |
|
@lokeshchdhry master-PR passed the CR, so I think you are fine 😇. |
|
@hansemannn , cool. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-24799
Backport of #9134
Bad things happen if a theme is a parent of itself, so we should prevent that