Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-25970] Android: 'postlayout' event not working for Picker with type Titanium.UI.PICKER_TYPE_DATE #10005

Merged
merged 13 commits into from May 16, 2018
Merged

[TIMOB-25970] Android: 'postlayout' event not working for Picker with type Titanium.UI.PICKER_TYPE_DATE #10005

merged 13 commits into from May 16, 2018

Conversation

ypbnv
Copy link
Contributor

@ypbnv ypbnv commented Apr 17, 2018

JIRA: https://jira.appcelerator.org/browse/TIMOB-25970

Description:
Fire postlayout event from Picker with type Ti.UI.PICKER_TYPE_DATE on Android.

Test case:
app.js

var win = Ti.UI.createWindow();
picker = Ti.UI.createPicker({type: Ti.UI.PICKER_TYPE_DATE});
picker.addEventListener('postlayout', function() {
    alert('Post layout!');
});
win.add(picker);
win.open();
//picker.showDatePickerDialog();

@ypbnv
Create custom class, extending DatePicker to provide postlayout event…
7f1be49 
… for Picker in layout.

Add listener to DatePicker dialog for onShow.
@ypbnv ypbnv added this to the 7.2.0 milestone Apr 17, 2018
@ypbnv ypbnv requested a review from garymathews April 17, 2018 14:20
@lokeshchdhry
Copy link
Contributor

FR Passed.

postLayout event is fired for API 19 & above & once for API below 19.

Studio Ver: 5.1.0.201804161553
SDK Ver: 7.2.0 local build
OS Ver: 10.13.4
Xcode Ver: Xcode 9.3
Appc NPM: 4.2.13-2
Appc CLI: 7.0.3-master.38
Daemon Ver: 1.1.1
Ti CLI Ver: 5.1.0
Alloy Ver: 1.12.0
Node Ver: 8.9.1
NPM Ver: 5.5.1
Java Ver: 10
Devices: ⇨ google Nexus 6P --- Android 8.0.0
⇨ google Nexus 5 --- Android 6.0.1
Emulator: Android 4.2.2

garymathews
garymathews suggested changes Apr 30, 2018
View reviewed changes
android/modules/ui/src/java/ti/modules/titanium/ui/widget/picker/CustomDatePicker.java Outdated
protected void onLayout(boolean changed, int left, int top, int right, int bottom)
{
super.onLayout(changed, left, top, right, bottom);
if (this.proxy != null) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could consolidate this statement?

if (this.proxy != null && changed) {

@ypbnv
Copy link
Contributor Author

ypbnv commented May 2, 2018

@garymathews Updated.

@build build added the android label May 2, 2018
@build
Copy link
Contributor

build commented May 12, 2018 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

@sgtcoolguy sgtcoolguy modified the milestones: 7.2.0, 7.3.0 May 16, 2018
@lokeshchdhry lokeshchdhry merged commit cd91879 into tidev:master May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garymathews garymathews garymathews requested changes

Assignees
No one assigned
Labels
android bug
Projects
None yet
Milestone
7.3.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@ypbnv @lokeshchdhry @build @garymathews @sgtcoolguy @jquick-axway