[TIMOB-25971] : iOS minimumFontSize property in Ti.UI.label lowers text baseline as it decreases #10006
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…xt baseline as it decreases
Generated by 🚫 dangerJS |
…xt baseline as it decreases
hansemannn
reviewed
Apr 19, 2018
| @@ -463,6 +463,7 @@ - (void)setMinimumFontSize_:(id)size | |||
| [label setAdjustsFontSizeToFitWidth:YES]; | |||
| CGFloat ratio = minFontSize / label.font.pointSize; | |||
| [label setMinimumScaleFactor:ratio]; | |||
| [label setBaselineAdjustment:UIBaselineAdjustmentNone]; | |||
There was a problem hiding this comment.
Good fix! I am wondering what the baseline-adjustment is before setting this? Since UIBaselineAdjustmentNone is already the default. And should we expose this as a property as well? Are there use-cases in our environment for this? And Android parity? Definitely as an own ticket, but maybe not even relevant.
There was a problem hiding this comment.
Default is UIBaselineAdjustmentAlignBaselines. This property is only relevant with "adjustsFontSizeToFitWidth" = true. I don't think it is more relevant to expose, if we have already expose property minimumFontSize which includes minimumScaleFactor and adjustsFontSizeToFitWidth.
hansemannn
approved these changes
Apr 19, 2018
Generated by 🚫 dangerJS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-25971