Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-26032] iOS/Android: Fix Ti.Contacts parity, deprecate old API's properly #10038

Merged
merged 15 commits into from Oct 24, 2018
Merged

[TIMOB-26032] iOS/Android: Fix Ti.Contacts parity, deprecate old API's properly #10038

merged 15 commits into from Oct 24, 2018

Conversation

hansemannn
Copy link
Collaborator

JIRA: https://jira.appcelerator.org/browse/TIMOB-26032

no tests because it only refactors existing code. Also requires UI-related interaction (contacts permissions, selecting values from the modal dialog).

@hansemannn hansemannn added this to the 7.3.0 milestone May 11, 2018
@hansemannn hansemannn changed the title [TIMOB-26032] [TIMOB-26032] iOS/Android: Fix Ti.Contacts parity, deprecate old API's properly May 11, 2018
@build
Copy link
Contributor

build commented May 11, 2018 •
edited

Fails
🚫

😥 npm test failed. See below for details.
Messages
📖 
> titanium-mobile@7.4.0 test /Users/build/jenkins/workspace/dk_titanium_mobile_PR-10038-3MWAUH4WGFM6UMBQUHUHXBKOFS5LTGFT46C3NRGXCUKXMG726EGQ
> grunt

Running "appcJs:src:lintOnly" (appcJs) task

Running "eslint:src" (eslint) task

Running "checkFormat:ios" (checkFormat) task

Running "checkFormat:android" (checkFormat) task
Fatal error: Error: Formatting incorrect on "android/modules/contacts/src/java/ti/modules/titanium/contacts/ContactsModule.java", proposed changes: <?xml version='1.0'?>
<replacements xml:space='preserve' incomplete_format='false'>
<replacement offset='4141' length='0'>&#10;			</replacement>
<replacement offset='4145' length='1'>&#10;			</replacement>
<replacement offset='4270' length='1'>&#10;			</replacement>
</replacements>
�
npm ERR! Test failed.  See above for more details.

Generated by 🚫 dangerJS

sgtcoolguy
sgtcoolguy suggested changes May 11, 2018
View reviewed changes
Copy link
Contributor

@sgtcoolguy sgtcoolguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The deprecation note on Android has a type in the correct method name. Added suggested fixed text.

android/modules/contacts/src/java/ti/modules/titanium/contacts/ContactsModule.java Outdated
@@ -136,6 +136,13 @@ public void save(Object people)

@Kroll.method
public PersonProxy getPersonByID(long id)
{
Log.w(TAG, "getPersonByID has been deprecated in favor of getPersonById (parity)", Log.DEBUG_MODE);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

Log.w(TAG, "Ti.Contacts.getPersonByID() has been deprecated in favor of Ti.Contacts.getPersonByIdentifier() for cross-platform parity", Log.DEBUG_MODE);

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated!

@sgtcoolguy sgtcoolguy modified the milestones: 7.3.0, 7.4.0 May 16, 2018
@build
Copy link
Contributor

build commented Jun 25, 2018 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

vijaysingh-axway
vijaysingh-axway approved these changes Jun 25, 2018
View reviewed changes
Copy link
Contributor

@vijaysingh-axway vijaysingh-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR passed.
Note - @hansemannn There seems linting issue in Contacts.java as build is failing. Can you fix that.

@hansemannn hansemannn modified the milestones: 7.4.0, 7.3.1, 7.5.0 Aug 24, 2018
@lokeshchdhry
Copy link
Contributor

FR Passed.

@lokeshchdhry lokeshchdhry merged commit 7b99ea1 into tidev:master Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgtcoolguy sgtcoolguy sgtcoolguy requested changes

@vijaysingh-axway vijaysingh-axway vijaysingh-axway approved these changes

@jquick-axway jquick-axway Awaiting requested review from jquick-axway

@garymathews garymathews Awaiting requested review from garymathews

Assignees
No one assigned
Labels
android docs ios no tests
Projects
None yet
Milestone
7.5.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@hansemannn @build @lokeshchdhry @sgtcoolguy @vijaysingh-axway @ssjsamir @keerthi1032