Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[7_2_X][TIMOB-26003] Android: Provide API to support opt-out of Analytics at runtime #10059

Merged
merged 9 commits into from Jun 4, 2018
Merged

[7_2_X][TIMOB-26003] Android: Provide API to support opt-out of Analytics at runtime #10059

merged 9 commits into from Jun 4, 2018

Conversation

ypbnv
Copy link
Contributor

@ypbnv ypbnv commented May 17, 2018

@ypbnv ypbnv added this to the 7.2.0 milestone May 17, 2018
@ypbnv ypbnv requested a review from garymathews May 17, 2018 14:22
@build build added the android label May 17, 2018
@lokeshchdhry
Copy link
Contributor

@ypbnv , Can you please fix the build failure due to missing symbol.

@build build added the android label May 22, 2018
@build
Copy link
Contributor

build commented May 23, 2018 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

@ypbnv
Copy link
Contributor Author

ypbnv commented May 30, 2018

Updated with the latest changes in master PR.

garymathews
garymathews approved these changes May 31, 2018
View reviewed changes
Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: PASS

@lokeshchdhry
Copy link
Contributor

FR Passed.

The optOut property seems to work as expected. When optOut = true no analytics events are sent from the device & warning is thrown as below.

[WARN] :   APSAnalytics: APSAnalytics has not been enabled or the user opted out. Please enable Analytics and ensure the user has not opted out.

With optOut = false, analytics events are sent successfully.

In depth tests are on this wiki page : https://wiki.appcelerator.org/display/qe/GDPR+Analytics+testing

Studio Ver: 5.1.0.201805300954
SDK Ver: 7.2.0 local build
OS Ver: 10.13.4
Xcode Ver: Xcode 9.4
Appc NPM: 4.2.13
Appc CLI: 7.0.4-master.2
Daemon Ver: 1.1.3
Ti CLI Ver: 5.1.0
Alloy Ver: 1.12.0
Node Ver: 8.9.1
NPM Ver: 5.5.1
Java Ver: 10
Devices: ⇨ google Nexus 5 --- Android 6.0.1
⇨ google Nexus 6P --- Android 8.1.0

@lokeshchdhry lokeshchdhry merged commit e93bdc1 into tidev:7_2_X Jun 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garymathews garymathews garymathews approved these changes

Assignees
No one assigned
Labels
android no tests
Projects
None yet
Milestone
7.2.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ypbnv @lokeshchdhry @build @garymathews