Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-26062] iOS: Fix all Xcode Analyzer warnings & possible leaks #10072

Merged
merged 4 commits into from May 25, 2018

Conversation

hansemannn
Copy link
Collaborator

@hansemannn hansemannn commented May 22, 2018

JIRA: https://jira.appcelerator.org/browse/TIMOB-26062

For most of the changes, we either already had unit-tests or they were IDE-related (clang-analyzer). For the zoomLevel, I have added a new unit test that passes.

@build
Copy link
Contributor

build commented May 25, 2018

Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

@hansemannn hansemannn added the bug label May 25, 2018
@hansemannn
Copy link
Collaborator Author

@sgtcoolguy I would like to include this in 7.3.0 if you agree.

Copy link
Contributor

@vijaysingh-axway vijaysingh-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR passed.

@sgtcoolguy sgtcoolguy merged commit 546468b into tidev:master May 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants