Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-26071] TiAPI: Add Ti.WebDialog to core-modules #10078

Merged
merged 1 commit into from Jun 7, 2018
Merged

[TIMOB-26071] TiAPI: Add Ti.WebDialog to core-modules #10078

merged 1 commit into from Jun 7, 2018

Conversation

hansemannn
Copy link
Collaborator

@build
Copy link
Contributor

build commented May 28, 2018

Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

@sgtcoolguy sgtcoolguy added this to the 8.0.0 milestone May 31, 2018
@sgtcoolguy
Copy link
Contributor

Actually, this is not a breaking change as the safari dialog module wasn't removed here. I think we can merge this for 7.4 and remove ti.safaridialog in 8.0.0 (Normally we'd have to deprecate and warn with a longer cycle, but I think given that devs can just grab the module themselves if they still haven't migrated that's it's not quite so bad).

@sgtcoolguy sgtcoolguy modified the milestones: 8.0.0, 7.4.0 May 31, 2018
@sgtcoolguy sgtcoolguy merged commit ee492ba into tidev:master Jun 7, 2018
@hansemannn hansemannn modified the milestones: 7.4.0, 7.5.0 Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgtcoolguy sgtcoolguy sgtcoolguy approved these changes

Assignees
No one assigned
Labels
android feature ios
Projects
None yet
Milestone
7.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hansemannn @build @sgtcoolguy