[TIMOB-26079] Continue build on invalid Android library ABI #10084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
|
As the comment describes, we use the |
sgtcoolguy
approved these changes
Jun 12, 2018
android/cli/commands/_build.js
Outdated
| store: store | ||
| }); | ||
| entryNames.push(entry.entryName); | ||
| this.logger.debug('test3'); |
There was a problem hiding this comment.
Remove this straggler debug log, please
Generated by 🚫 dangerJS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-26079
Optional Description:
This aligns the handling of invalid ABIs for native libraries from Android .aar files to be the same as in the other stages of creating the APK archive.
@cb1kenobi I had to remove the override for
console.errorbecause that caused all ourdebugandwarnmessages to not show up. I'm sure you had your reason to temporarily override it. Do you remember why and if there is a better way to do this nowadays? The comment said something about to many event listeners but i couldn't see anything when testing this.