Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS: Update ioslib to 1.7.1, adding Node 10- and Xcode 10 support #10089

Merged
merged 3 commits into from Jun 8, 2018
Merged

iOS: Update ioslib to 1.7.1, adding Node 10- and Xcode 10 support #10089

merged 3 commits into from Jun 8, 2018

Conversation

hansemannn
Copy link
Collaborator

@hansemannn hansemannn commented Jun 5, 2018 •
edited

JIRA: https://jira.appcelerator.org/browse/TIMOB-26096

NOTE: This can only be merged once 7_3_X is branched and master is at least 7.4.0.

@hansemannn hansemannn added this to the 7.4.0 milestone Jun 5, 2018
@hansemannn hansemannn requested a review from cb1kenobi June 5, 2018 21:05
@hansemannn hansemannn removed this from the 7.4.0 milestone Jun 5, 2018
@hansemannn hansemannn changed the title Update ioslib to 1.7.0, adding Node 10- and Xcode 10 support iOS: Update ioslib to 1.7.0, adding Node 10- and Xcode 10 support Jun 5, 2018
@ewanharris ewanharris mentioned this pull request Jun 5, 2018
Merged
@hansemannn hansemannn added this to the 7.4.0 milestone Jun 7, 2018
@sgtcoolguy sgtcoolguy self-requested a review June 8, 2018 14:02
sgtcoolguy
sgtcoolguy approved these changes Jun 8, 2018
View reviewed changes
Copy link
Contributor

@sgtcoolguy sgtcoolguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sgtcoolguy
Copy link
Contributor

Looks like this won't build on Jenkins due to the ioslib download-all script failing?

@sgtcoolguy sgtcoolguy changed the title iOS: Update ioslib to 1.7.0, adding Node 10- and Xcode 10 support iOS: Update ioslib to 1.7.1, adding Node 10- and Xcode 10 support Jun 8, 2018
@build
Copy link
Contributor

build commented Jun 8, 2018

Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

@sgtcoolguy sgtcoolguy merged commit 6eb40b0 into tidev:master Jun 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgtcoolguy sgtcoolguy sgtcoolguy approved these changes

@cb1kenobi cb1kenobi Awaiting requested review from cb1kenobi

Assignees
No one assigned
Labels
improvement in-qe-testing 🕵 ios no tests
Projects
None yet
Milestone
7.4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hansemannn @sgtcoolguy @build