Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-26103] iOS 12: Expose new UserNotifications API's #10091

Merged
merged 15 commits into from Jul 30, 2018
Merged

[TIMOB-26103] iOS 12: Expose new UserNotifications API's #10091

merged 15 commits into from Jul 30, 2018

Conversation

hansemannn
Copy link
Collaborator

@hansemannn hansemannn commented Jun 6, 2018 •
edited

@hansemannn hansemannn added this to the 7.4.0 milestone Jun 7, 2018
@hansemannn
Copy link
Collaborator Author

@sgtcoolguy Is it already possible to build with Xcode 10 Beta as of for now? We are 3 months early this time :-).

@tidev tidev deleted a comment from build Jun 30, 2018
vijaysingh-axway
vijaysingh-axway suggested changes Jul 2, 2018
View reviewed changes
Copy link
Contributor

@vijaysingh-axway vijaysingh-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I can see that "threadIdentifier" api is not exposed, which can be used to visually group notification. Please expose this.
  2. If you can give a test case would help qe to test it. Thanks!

@build
Copy link
Contributor

build commented Jul 4, 2018 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

@hansemannn
Copy link
Collaborator Author

@vijaysingh-axway Pushed the changes, added an example.

vijaysingh-axway
vijaysingh-axway approved these changes Jul 30, 2018
View reviewed changes
Copy link
Contributor

@vijaysingh-axway vijaysingh-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR passed.

@hansemannn hansemannn merged commit a64c68f into tidev:master Jul 30, 2018
sgtcoolguy pushed a commit that referenced this pull request Aug 27, 2018
@hansemannn @sgtcoolguy
[TIMOB-26103] iOS 12: Expose new UserNotifications API's (#10091)
c352cb8 
* [TIMOB-26103] First stage of adding the new UserNotifications API's

* Fix method access for two methods, fix 7.2.0 -> 7.3.0, fix docs (#10093)

* Add docs

* Update docs, fix typo

* Add Ti.App.iOS unit tests

* Update ti.app.ios.searchquery.test.js

* Update ti.app.ios.test.js

* feat: expose "threadIdentifier", fix: "timezone" property in notifications

* Some final improvements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vijaysingh-axway vijaysingh-axway vijaysingh-axway approved these changes

Assignees
No one assigned
Labels
docs feature ios
Projects
None yet
Milestone
7.4.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hansemannn @build @vijaysingh-axway @sgtcoolguy