Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-26130] Android: Remove flag that breaks NDK compatibility #10110

Merged
merged 2 commits into from Jun 18, 2018
Merged

[TIMOB-26130] Android: Remove flag that breaks NDK compatibility #10110

merged 2 commits into from Jun 18, 2018

Conversation

garymathews
Copy link
Contributor

  • Remove -flto link-time optimization to preserve NDK 12+ compatibility
TEST CASE
  • Set ANDROID_NDK environment variable to NDK 17
  • Compile Titanium SDK successfully

JIRA Ticket

@garymathews garymathews added this to the 7.4.0 milestone Jun 14, 2018
@build
Copy link
Contributor

build commented Jun 14, 2018 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

sgtcoolguy
sgtcoolguy approved these changes Jun 18, 2018
View reviewed changes
Copy link
Contributor

@sgtcoolguy sgtcoolguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I was able to build via: ./scons clean build android -n /opt/android-ndk-17

@sgtcoolguy sgtcoolguy merged commit 9efc665 into tidev:master Jun 18, 2018
@ypbnv
Copy link
Contributor

ypbnv commented Jul 17, 2018

@garymathews Do we want that to be backported for 7_3_X?

@jquick-axway jquick-axway mentioned this pull request Aug 8, 2018
Merged
@jquick-axway
Copy link
Contributor

I've back-ported it. The back-port is intended for 7.3.1. See here: #10240
(Community members were getting burned by this.)

@jquick-axway jquick-axway mentioned this pull request Aug 21, 2018
Merged
@hansemannn hansemannn modified the milestones: 7.4.0, 7.5.0 Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgtcoolguy sgtcoolguy sgtcoolguy approved these changes

Assignees
No one assigned
Labels
android bug
Projects
None yet
Milestone
7.5.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@garymathews @build @ypbnv @jquick-axway @sgtcoolguy @hansemannn