New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-26131] Android: Do not copy geolocation libs #10127
Conversation
build/android.js
Outdated
@@ -111,6 +111,12 @@ Android.prototype.package = function (packager, next) { | |||
function (cb) { | |||
const moduleDirs = fs.readdirSync(path.join(ANDROID_ROOT, 'modules')); | |||
async.each(moduleDirs, function (dir, callback) { | |||
|
|||
// skip geolocation | |||
if ([ 'gelocation' ].includes(dir)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
gelocation?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: Pass
@garymathews Jenkins seems to continuously fail with this PR. Did you test the changes locally already? |
build/android.js
Outdated
|
||
// skip geolocation | ||
if ([ 'geolocation' ].includes(dir)) { | ||
return; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're never calling the callback, so I don't think this ever properly returns.
Generated by 🚫 dangerJS |
play-service-*.jar
filesJIRA Ticket