Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-26141] Android: Prevent lookup of invalid reference key #10129

Merged
merged 5 commits into from Jun 26, 2018

Conversation

garymathews
Copy link
Contributor

  • Prevent lookup of invalid reference key 0
  • Remove annoying error log No valid root or current activity found for application instance
TEST CASE
console.log(Ti.App.Android.R);

JIRA Ticket

@build
Copy link
Contributor

build commented Jun 22, 2018

Messages
📖

👍 Hey!, You deleted more code than you added. That's awesome!

📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

Copy link
Contributor

@ypbnv ypbnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@ypbnv
Copy link
Contributor

ypbnv commented Jun 25, 2018

@garymathews I tried to track why does it end with a refTableKey_ equal to 0, but I did not got it. Any idea about that?

@garymathews
Copy link
Contributor Author

@ypbnv refTableKey_ is initialised as 0. This is considered an invalid key, only keys greater than zero should be looked up. getJavaObject() is called before a Java object is attached, which causes this invalid lookup.

@hansemannn hansemannn merged commit 89af071 into tidev:master Jun 26, 2018
@jquick-axway jquick-axway modified the milestones: 7.4.0, 7.5.0 Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants