Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-26161] Android: Allow activity events on UI thread #10137

Merged
merged 6 commits into from Jun 30, 2018
Merged

[TIMOB-26161] Android: Allow activity events on UI thread #10137

merged 6 commits into from Jun 30, 2018

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews commented Jun 27, 2018 •
edited

  • Fix activity lifecycle callbacks when running on main thread
TEST CASE
const win = Ti.UI.createWindow({ backgroundColor: 'gray' });

win.addEventListener('open', () => {
    const activity = Ti.Android.currentActivity;

    activity.onStart = () => {
        Ti.API.info('activity: onStart');
    };

    Ti.App._restart();
});

win.open();
  • Should see activity: onStart logs

JIRA Ticket

@garymathews garymathews added this to the 7.4.0 milestone Jun 27, 2018
@garymathews garymathews requested a review from ypbnv June 27, 2018 17:55
ypbnv
ypbnv approved these changes Jun 28, 2018
View reviewed changes
Copy link
Contributor

@ypbnv ypbnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@build
Copy link
Contributor

build commented Jun 28, 2018 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

@hansemannn hansemannn merged commit d9767b8 into tidev:master Jun 30, 2018
@jquick-axway jquick-axway modified the milestones: 7.4.0, 7.5.0 Aug 24, 2018
dieskim pushed a commit to dieskim/titanium_mobile that referenced this pull request Dec 21, 2018
@garymathews @dieskim
[TIMOB-26161] Allow activity events on UI thread (tidev#10137)
4f90099
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ypbnv ypbnv ypbnv approved these changes

Assignees
No one assigned
Labels
android bug in-qe-testing 🕵 no tests
Projects
None yet
Milestone
7.5.0
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@garymathews @build @ypbnv @hansemannn @jquick-axway