Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-26155] Android: Fix generatedDiffProperties() #10148

Merged
merged 2 commits into from Jul 3, 2018
Merged

[TIMOB-26155] Android: Fix generatedDiffProperties() #10148

merged 2 commits into from Jul 3, 2018

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews commented Jul 2, 2018 •
edited

  • Prevent properties from being reset to null
TEST CASE
  • See JIRA

JIRA Ticket

@garymathews garymathews added this to the 7.4.0 milestone Jul 2, 2018
@garymathews garymathews requested a review from ypbnv July 2, 2018 21:47
@build
Copy link
Contributor

build commented Jul 2, 2018 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

ypbnv
ypbnv approved these changes Jul 3, 2018
View reviewed changes
Copy link
Contributor

@ypbnv ypbnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hansemannn hansemannn merged commit b9c7b1c into tidev:master Jul 3, 2018
@hansemannn hansemannn modified the milestones: 7.4.0, 7.5.0 Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ypbnv ypbnv ypbnv approved these changes

Assignees
No one assigned
Labels
android bug in-qe-testing 🕵 no tests
Projects
None yet
Milestone
7.5.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@garymathews @build @ypbnv @hansemannn