Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-26187] Android: Fix Ti.UI.CardView borderRadius #10157

Merged
merged 7 commits into from Jul 12, 2018

Conversation

garymathews
Copy link
Contributor

  • TiUICardView has its own border, prevent TiUIView from creating a border wrapper for our view
TEST CASE
const win = Ti.UI.createWindow({ backgroundColor: 'gray' }),
      card = Ti.UI.Android.createCardView({
          padding: 20,
          backgroundColor: 'white',
          borderRadius: 10
      });

card.add(Ti.UI.createLabel({
    color: 'black',
    text: 'THIS IS A TEST!'
}));

win.add(card);
win.open();

JIRA Ticket

@build
Copy link
Contributor

build commented Jul 9, 2018

Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

@lokeshchdhry
Copy link
Contributor

FR Passed.

The cardview is visible with borderradius set.

Studio Ver: 5.1.0.201807090554
OS Ver: 4.2.13
Xcode Ver: 7.0.4
Appc NPM: 1.1.3
Appc CLI: 10.13.5
Daemon Ver: Xcode 9.4.1
Ti CLI Ver: 5.1.1
Alloy Ver: 1.12.0
Node Ver: 8.9.1
NPM Ver: 5.5.1
Java Ver: 1.8.0_131
Devices: ⇨ google Nexus 5 --- Android 6.0.1
⇨ google Nexus 6P --- Android 8.1.0
Emulator: ⇨ Android 4.1.2

Copy link
Contributor

@ypbnv ypbnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we not support borders for CardView in general ?

@garymathews
Copy link
Contributor Author

garymathews commented Jul 11, 2018

@ypbnv the native CardView component has its own border handling. You can only set the borderRadius of a CardView. Which is why hasBorders will always return false on CardView.

Copy link
Contributor

@ypbnv ypbnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
One minor thing - Can we mark in the docs that only borderRadius is supported for CardView?

@hansemannn hansemannn merged commit aef3c1f into tidev:master Jul 12, 2018
@hansemannn hansemannn modified the milestones: 7.4.0, 7.5.0 Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants