Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-19618] Android: Implement Ti.UI.WebView.mixedContentMode #10186

Merged
merged 10 commits into from Aug 7, 2018

Conversation

garymathews
Copy link
Contributor

  • Allows the loading of insecure resources from a secure origin
TEST CASE
const win = Ti.UI.createWindow({ backgroundColor: 'gray' }),
      webView = Ti.UI.createWebView({
          url: 'https://www.bennish.net/mixed-content.html',
          mixedContentMode: true
      });

win.add(webView);
win.open();

JIRA Ticket

platforms: [android]
since: "7.4.0"
default: false

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we only set this upon creation, we need...
availability: creation

The rest looks great. Thanks!

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And perhaps in the description we should state that iOS users should use the NSAllowsArbitraryLoads plist setting.

Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

@build
Copy link
Contributor

build commented Aug 7, 2018

Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

@hansemannn hansemannn merged commit 2cde006 into tidev:master Aug 7, 2018
@jquick-axway jquick-axway modified the milestones: 7.4.0, 7.5.0 Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants