Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-25955] Support crash analytics refactor #10190

Merged
merged 2 commits into from Nov 20, 2018
Merged

[TIMOB-25955] Support crash analytics refactor #10190

merged 2 commits into from Nov 20, 2018

Conversation

garymathews
Copy link
Contributor

  • Support recent crash analytics refactor

JIRA Ticket

@garymathews garymathews changed the title [TIMOB-25955] Android: Support crash analytics refactor [TIMOB-25955] Support crash analytics refactor Jul 19, 2018
@build build added the ios label Jul 19, 2018
@garymathews garymathews added this to the 8.0.0 milestone Aug 17, 2018
@hansemannn hansemannn changed the base branch from master to next August 17, 2018 17:30
@garymathews garymathews changed the base branch from next to master August 17, 2018 17:31
@garymathews garymathews changed the base branch from master to next August 17, 2018 17:31
@garymathews garymathews changed the base branch from next to master August 17, 2018 21:00
@build
Copy link
Contributor

build commented Aug 27, 2018 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

@garymathews garymathews force-pushed the TIMOB-25955 branch 2 times, most recently from b117384 to bbcf5ae Compare September 4, 2018 23:21
sgtcoolguy
sgtcoolguy reviewed Oct 2, 2018
View reviewed changes
iphone/Classes/KrollContext.m Outdated
@@ -659,7 +659,6 @@ - (void)invoke:(KrollContext *)context
id excm = [KrollObject toID:context value:exception];
[[TiExceptionHandler defaultExceptionHandler] reportScriptError:[TiUtils scriptErrorValue:excm]];
pthread_mutex_unlock(&KrollEntryLock);
@throw excm;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why not throw the exception?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already handle the exception on the lines above. Throwing an exception causes the app to crash with an exception that cannot be caught since it's throwing a KrollObject and not a valid exception.

@sgtcoolguy
Copy link
Contributor

@garymathews With the merge from next branch, the APSAnalytics and Kroll classes have changed locations in the repo and are part of the pre-built TitaniumKit framework. I assume that's the cause of the conflicts.

@garymathews garymathews merged commit 98fc928 into tidev:master Nov 20, 2018
vijaysingh-axway pushed a commit to vijaysingh-axway/titanium_mobile that referenced this pull request Nov 22, 2018
@garymathews @vijaysingh-axway
[TIMOB-25955] Support crash analytics refactor (tidev#10190)
d441911
build pushed a commit to hansemannn/titanium_mobile that referenced this pull request Dec 3, 2018
@garymathews @sgtcoolguy
[TIMOB-25955] Support crash analytics refactor (tidev#10190)
d0730b4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgtcoolguy sgtcoolguy sgtcoolguy left review comments

Assignees
No one assigned
Labels
android improvement ios no tests
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@garymathews @build @sgtcoolguy