Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-26202] Android: Improve memory management #10195

Merged
merged 2 commits into from Jul 26, 2018
Merged

[TIMOB-26202] Android: Improve memory management #10195

merged 2 commits into from Jul 26, 2018

Conversation

garymathews
Copy link
Contributor

@garymathews garymathews commented Jul 21, 2018 •
edited by jquick-axway

JIRA Ticket

@garymathews garymathews added this to the 7.4.0 milestone Jul 21, 2018
@garymathews garymathews force-pushed the TIMOB-26202_2 branch 2 times, most recently from 27cb2a4 to a411918 Compare July 21, 2018 06:21
@garymathews garymathews mentioned this pull request Jul 21, 2018
Merged
@garymathews garymathews force-pushed the TIMOB-26202_2 branch 5 times, most recently from 09e3cf4 to d2a9f3a Compare July 23, 2018 06:20
@jquick-axway
Copy link
Contributor

@lokeshchdhry, Gary plans on making one more change to this PR. But afterwards, would you mind running this PR though the KitchenSink app please? Thanks.

@garymathews garymathews mentioned this pull request Jul 24, 2018
Merged
@garymathews garymathews force-pushed the TIMOB-26202_2 branch 4 times, most recently from 00781e4 to 3f9645a Compare July 25, 2018 00:31
@garymathews garymathews changed the title [TIMOB-26202] Android: Fix Ti.UI.Window references [TIMOB-26202] Android: Improve memory management Jul 25, 2018
@garymathews garymathews force-pushed the TIMOB-26202_2 branch 3 times, most recently from 596dee7 to 836f55e Compare July 25, 2018 23:56
@build
Copy link
Contributor

build commented Jul 26, 2018 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

sgtcoolguy
sgtcoolguy reviewed Jul 26, 2018
View reviewed changes
android/kroll-apt/src/java/org/appcelerator/kroll/annotations/generator/ProxyBindingV8.cpp.fm Outdated
if (!JavaObject::isJavaObject(holder)) {
holder = holder->FindInstanceInPrototypeChain(getProxyTemplate(isolate));
}

if (holder.IsEmpty() || holder->IsNull()) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this repeated code chunk into a method/macro? And possibly add some logging when we hit these edge cases that shouldn't be occurring?

@lokeshchdhry
Copy link
Contributor

FR Passed.

@lokeshchdhry lokeshchdhry merged commit d9fdabc into tidev:master Jul 26, 2018
@hansemannn hansemannn modified the milestones: 7.4.0, 7.5.0 Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgtcoolguy sgtcoolguy sgtcoolguy left review comments

@jquick-axway jquick-axway Awaiting requested review from jquick-axway

Assignees
No one assigned
Labels
android bug no tests
Projects
None yet
Milestone
7.5.0
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@garymathews @jquick-axway @build @lokeshchdhry @sgtcoolguy @hansemannn