Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-26209] Only error out if selected xcode EULA has not been acce… #10205

Merged
merged 3 commits into from Jul 26, 2018

Conversation

feons
Copy link
Contributor

@feons feons commented Jul 24, 2018

…pted

JIRA: https://jira.appcelerator.org/browse/TIMOB-26209
If any Xcode installs don't have EULA accepted (even one not being used), build won't work.

@feons feons requested a review from cb1kenobi July 24, 2018 21:59
@cb1kenobi
Copy link
Contributor

@feons This PR also needs to update the package-lock.json. Apparently running npm install will fix it, but that will probably also update a bunch of other things too.

@hansemannn hansemannn added this to the 7.4.0 milestone Jul 26, 2018
@build
Copy link
Contributor

build commented Jul 26, 2018

Messages
📖

👍 Hey!, You deleted more code than you added. That's awesome!

📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

@hansemannn hansemannn merged commit a76b0ff into tidev:master Jul 26, 2018
sgtcoolguy pushed a commit that referenced this pull request Jul 27, 2018
#10205)

* [TIMOB-26209] Only error out if selected xcode EULA has not been accepted

* Update package-lock.json
@hansemannn hansemannn modified the milestones: 7.4.0, 7.5.0 Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants