Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7_3_X][TIMOB-26240] Android: Removed harmless activity errors/warnings logged on startup #10220

Merged
merged 2 commits into from Jul 31, 2018

Conversation

jquick-axway
Copy link
Contributor

@jquick-axway jquick-axway commented Jul 30, 2018

JIRA:
https://jira.appcelerator.org/browse/TIMOB-26240

Cherry-pick of: #10219

Removed additional error message not present in Titanium 7.4.0...
e5ff1c5

…ed on startup

- Changed TiApplication.getInstance() handling:
  * Changed "tiApp" from weak reference to strong. Guaranteed to exist for lifetime of app, so, it was unnecessary.
  * Removed TiApplication.getInstance() null checks.
@build
Copy link
Contributor

build commented Jul 30, 2018

Messages
📖

👍 Hey!, You deleted more code than you added. That's awesome!

📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@hansemannn hansemannn merged commit 065f72d into tidev:7_3_X Jul 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants