[TIMOB-24605] Android: Fixed crashes caused by loading image URLs when JS is running on main thread

[jquick-axway]

JIRA:

• https://jira.appcelerator.org/browse/TIMOB-24605
• https://jira.appcelerator.org/browse/TIMOB-26249

Summary:

• Fixed image URL crash if JS running on main thread for:
  • TIMOB-24605 View object's "backgroundImage" property.
  • TIMOB-26249 ImageView object's image property while "autorotate" is true.
  • ImageView object's "defaultImage" property.
• Modified Java "TiImageHelper" class to support reading JPEG EXIF orientation from a stream.
  • Allows ImageView to auto-rotate JPEG downloaded from the Internet if needed.
• Added new Java class "TiInputStreamWrapper".
  • Used to close the HttpUrlConnection when the stream has been closed.
• Added redirect endpoint fetching methods to Java "TiResponseCache".
  • Needed to fetch cached image when using a URL that redirects. Major optimization.

---

Test 1:

1. Uninstall the app from the device if already installed. (Will delete cached web responses.)
2. Make sure the Android device has Internet access.
3. Set "tiapp.xml" file property "run-on-main-thread" to true.
4. Build and run the below code.
5. Verify that the image was successfully displayed without crashing.

var window = Ti.UI.createWindow();
window.add(Ti.UI.createView({
	// This URL redirects from HTTP to HTTPS.
	backgroundImage: "http://raw.githubusercontent.com/recurser/exif-orientation-examples/master/Portrait_1.jpg",
}));
window.open();

---

Test 2:

1. Uninstall the app from the device if already installed. (Will delete cached web responses.)
2. Make sure the Android device has Internet access.
3. Set "tiapp.xml" file property "run-on-main-thread" to true.
4. Build and run the below code.
5. Verify that the image was displayed "upright" successfully, without crashing.

var window = Ti.UI.createWindow();
var imageView = Ti.UI.createImageView({
	// This URL redirects from HTTP to HTTPS.
	image: "http://raw.githubusercontent.com/recurser/exif-orientation-examples/master/Portrait_3.jpg",
	autorotate: true,
});
window.add(imageView);
window.open();

[garymathews]

Instead of creating an anonymous class, you should be able to do this:

public InputStream blockingDownload(final URI uri)
{
...
	// Perform the blocking download.
	try {
		Thread downloadThread = new Thread(new Runnable() {
			@Override
			public void run() {
				try (InputStream stream = blockingDownload(uri)) {
					if (stream != null) {
						KrollStreamHelper.pump(stream, null);
					}
				} catch (Exception ex) {
				}
			}
		});
		downloadThread.start();

		// wait for thread to finish
		downloadThread.join();
	} catch (Exception ex) {
	}
	...
...

[garymathews]

Maybe log a warning if there's a bad response (404?), or throw an exception?

You can test with https://httpbin.org/status/404

[jquick-axway]

Good point. The image property used to log a 404 warning and now it doesn't. I'll add some log messages.

Also, backgroundImage used to crash the app for a 404 response when "run-on-main-thread" was false. I've inadvertently fixed that. :)

[jquick-axway]

Updated PR

[garymathews]

CR: PASS

[build]

	Messages
📖	💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS