[TIMOB-26165] iOS: Fix requiring a JSON file with single quotes #10238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
sgtcoolguy
approved these changes
Aug 8, 2018
There was a problem hiding this comment.
LGTM, but please avoid the ambiguous require path used in your unit test. It works, but we will eventually end support for this bad Titanium style require.
Also, you could have added the test input file into tests/Resources/jsonfiles/amber.json here in this PR and not pushed it to the suite. (Would make it easier to see together and would make it easier to cherry-pick/port to other branches).
|
|
||
| describe('require()', function () { | ||
| it('JSON-based require() with single-quotes', function () { | ||
| var amber = require('json_files/amber'); |
There was a problem hiding this comment.
Don't use a bad require style 😏
var amber = require('./json_files/amber');There was a problem hiding this comment.
Updating now. I was not sure if changes to the the tests repository will be picked up during CI build, so I placed it in the main repo instead. Good to know!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-26165