[TIMOB-23995] iOS: Add __dirname and __filename to the global app.js scope #10241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
cb1kenobi
requested changes
Aug 9, 2018
| TiStringRef dirnameProperty = TiStringCreateWithCFString((CFStringRef) @"__dirname"); | ||
| TiStringRef filenameProperty = TiStringCreateWithCFString((CFStringRef) @"__filename"); | ||
| TiObjectSetProperty(jsContext, globalRef, dirnameProperty, [KrollObject toValue:kroll value:@"/"], kTiPropertyAttributeDontEnum | kTiPropertyAttributeReadOnly | kTiPropertyAttributeDontDelete, NULL); | ||
| TiObjectSetProperty(jsContext, globalRef, filenameProperty, [KrollObject toValue:kroll value:@"/app.js"], kTiPropertyAttributeDontEnum | kTiPropertyAttributeReadOnly | kTiPropertyAttributeDontDelete, NULL); |
There was a problem hiding this comment.
__filename should just be the filename, no /.
There was a problem hiding this comment.
It's with parity of the current implementation (for require'ish format). Then we should change it for both.
EDIT: It looks like node uses the full (absolute) path, interesting. How should we go?
Node example:
index.js
console.log('__filename = ' + __filename);> node index.js:
__filename = /Users/hknoechel/Documents/dev/test_node/index.js
cb1kenobi
approved these changes
Aug 9, 2018
There was a problem hiding this comment.
@hansemannn I'm sorry, I'm horribly mistaken. __filename is a full path. My bad.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-23995
Extended test-case to validate files
require()'d can be found in the linked JIRA.