Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-26209] Moved the Xcode EULA assertion from pre-validate to val… #10249

Merged
merged 6 commits into from Aug 14, 2018
Merged

[TIMOB-26209] Moved the Xcode EULA assertion from pre-validate to val… #10249

merged 6 commits into from Aug 14, 2018

Conversation

cb1kenobi
Copy link
Contributor

@cb1kenobi cb1kenobi commented Aug 13, 2018

[TIMOB-26209] Moved the Xcode EULA assertion from pre-validate to validate after an Xcode version has been chosen for the build.

JIRA: https://jira.appcelerator.org/browse/TIMOB-26209

…idate after an Xcode version has been chosen for the build.
@sgtcoolguy
Copy link
Contributor

@cb1kenobi I assume this PR now needs to be updated to include ioslib 1.7.5...

@sgtcoolguy
Copy link
Contributor

Also that we'll need a back port for 7_3_X

@build
Copy link
Contributor

build commented Aug 14, 2018

Fails
🚫

Tests have failed, see below for more information.

Messages
📖

💾 Here's the generated SDK zipfile.

Tests:

Classname Name Time Error
ios.Titanium.App.iOS UserNotificationCenter 0.001 file:///Users/build/Library/Developer/CoreSimulator/Devices/1E2

Generated by 🚫 dangerJS

@sgtcoolguy sgtcoolguy merged commit 9e478f0 into tidev:master Aug 14, 2018
@cb1kenobi cb1kenobi deleted the TIMOB-26209 branch August 14, 2018 20:29
@hansemannn hansemannn modified the milestones: 7.4.0, 7.5.0 Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants