Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-26300] iOS: Fix crash when using (deprecated) kroll-thread #10254

Merged
merged 6 commits into from Aug 15, 2018
Merged

[TIMOB-26300] iOS: Fix crash when using (deprecated) kroll-thread #10254

merged 6 commits into from Aug 15, 2018

Conversation

hansemannn
Copy link
Collaborator

JIRA: https://jira.appcelerator.org/browse/TIMOB-26300

Removed some dirty old hacks that caused the internal iOS API to go mad when not using main-thread. I confirmed that the ticket linked to the initial code (from SDK 3.0.0) still works.

@hansemannn hansemannn added this to the 7.4.0 milestone Aug 14, 2018
@build build added the ios label Aug 14, 2018
@build
Copy link
Contributor

build commented Aug 14, 2018 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

@hansemannn
Copy link
Collaborator Author

@sgtcoolguy Something is odd here. For example, the UserNotificationCenter test fails, but it really cannot fail, since it simply checks for being an object, which it is always.

@hansemannn hansemannn merged commit 1adeb81 into tidev:master Aug 15, 2018
@hansemannn hansemannn modified the milestones: 7.4.0, 7.5.0 Aug 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vijaysingh-axway vijaysingh-axway Awaiting requested review from vijaysingh-axway

Assignees
No one assigned
Labels
ios
Projects
None yet
Milestone
7.5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@hansemannn @build