Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-26300] (7_3_X) iOS: Fix crash when using (deprecated) kroll-thread #10255

Merged
merged 4 commits into from Aug 21, 2018
Merged

[TIMOB-26300] (7_3_X) iOS: Fix crash when using (deprecated) kroll-thread #10255

merged 4 commits into from Aug 21, 2018

Conversation

hansemannn
Copy link
Collaborator

JIRA: https://jira.appcelerator.org/browse/TIMOB-26300

Removed some dirty old hacks that caused the internal iOS API to go mad when not using main-thread. I confirmed that the ticket linked to the initial code (from SDK 3.0.0) still works.

@hansemannn hansemannn added this to the 7.3.1 milestone Aug 14, 2018
@build build added the ios label Aug 14, 2018
@vijaysingh-axway
Copy link
Contributor

Changes looks good.

vijaysingh-axway
vijaysingh-axway approved these changes Aug 17, 2018
View reviewed changes
Copy link
Contributor

@vijaysingh-axway vijaysingh-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR passed.

@build
Copy link
Contributor

build commented Aug 21, 2018

Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

@hansemannn hansemannn merged commit 0e4c581 into tidev:7_3_X Aug 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vijaysingh-axway vijaysingh-axway vijaysingh-axway approved these changes

Assignees
No one assigned
Labels
ios
Projects
None yet
Milestone
7.3.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hansemannn @vijaysingh-axway @build