[TIMOB-26314] Android: Add versionCode to tiapp.xml

[m1ga]

JIRA: https://jira.appcelerator.org/browse/TIMOB-26314

[garymathews]

LGTM

[build]

	Messages
📖	🎉 Another contribution from our awesome community member, m1ga! Thanks again for helping us make Titanium SDK better. 👍
📖	💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

[cb1kenobi]

Why do we need this? We already compute this when we write the AndroidManifest.xml: https://github.com/appcelerator/titanium_mobile/blob/82748c2cedaac99f9386a551c8b59b09322eb615/android/cli/commands/_build.js#L3721

[m1ga]

@cb1kenobi oh ok. Didn't see that part cause the other "variables" had placeholders. I'll remove that part but the versionCode is still nice to have in the default tiapp.xml

[cb1kenobi]

Sure, but we already have support for that via a custom android manifest section in the tiapp.xml:

<?xml version="1.0" encoding="UTF-8"?>
<ti:app xmlns:ti="http://ti.appcelerator.org">
    <android xmlns:android="http://schemas.android.com/apk/res/android">
        <manifest android:versionCode="2"/>
    </android>
</ti:app>

[m1ga]

yes, but it is not exposed in the default (template) tiapp.xml. You have to look up the parameter name if you don't know it. In this PR I just add it since it is a very default value you always need to change in every project

[cb1kenobi]

This is a welcome addition! Thanks for the contribution! APPROVED!!!

[lokeshchdhry]

FR Passed.

tiapp.xml is now by default populated with android:versionCode="1".

Studio Ver: 5.1.1.201809051655
SDK Ver: 7.5.0 local build
OS Ver: 10.13.5
Xcode Ver: Xcode 9.4.1
Appc NPM: 4.2.13
Appc CLI: 7.0.6
Daemon Ver: 1.1.3
Ti CLI Ver: 5.1.1
Alloy Ver: 1.13.2
Node Ver: 8.9.1
NPM Ver: 5.5.1
Java Ver: 10.0.2
Devices: ⇨ google Nexus 5 (Android 6.0.1)
⇨ google Nexus 6P (Android 8.1.0)

[garymathews]

Humm... adding versionCode seems to cause the tests to consistently fail?

[cb1kenobi]

I don't get why the tests are failing. This PR is just adding a versionCode to the project templates.

What's more confusing is Jenkins says that this PR's "changes" are in TCPProxy.java, not in the project template. Jenkins has some wires crossed.

[sgtcoolguy]

The last build failed because of the test that opens a Ti.Map in a TabGroup. That also failed on another PR. Seems to be an unrelated issue entirely, but looks to be an Android regression that has started recently. cc @garymathews