(7_3_X) [TIMOB-26325] Android: Ti.UI.WebView not firing events in 7.x #10273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
hansemannn
reviewed
Aug 21, 2018
| @@ -635,6 +635,10 @@ properties: | |||
| description: | | |||
| On the iOS platform, this is not per-webview. Once you have set this property for a webview | |||
| it will not change for same. But while creating new webview it can be changed to new user agent. | |||
|
|
|||
| On Android, changing the user agent after the webview has begun loading content may cause | |||
| the webview to reload and fire multiple `load` or `beforeLoad` events. Developers should provide the | |||
There was a problem hiding this comment.
Thanks for the catch Hans!
|
Merged manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-26325
Description:
This reverts the boolean flag hack to prevent multiple
load/beforeLoadevents getting fired when changing theuserAgentafter construction.When running through
processPropertieswe set the user agent string before loading the html/url/data content to avoid immediate reload.I think so long as you provide the user agent in the construction properties this should only ever fire the
load/beforeLoadevents once. If you construct a WebView with an Url and then change the user agent after (mid-load), it's entirely possible you'll get multipleload/beforeLoadevents fired based on the timing of the code.I included a quick blurb in the Ti.UI.WebView.userAgent apidocs about this behavior.