New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-26329] Android: Modified build to generate missing "R" classes for libraries added in 7.3.0 #10279
Conversation
…or libraries added in 7.3.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: PASS
But we should also remove the duplicate libs located in appcompat and add design
and compat
as dependencies of appcompat
FR Passed. Ran the Studio Ver: 5.1.0.201808080937 |
@jquick-axway , Are we done with this PR ? Also, can you please provide a 7.3.1 backport. |
I just tested this on Windows and it works. I wanted to make sure that the command line wasn't too long. @lokeshchdhry, thanks for testing this. I'm going to remove the redundant JAR files Gary found and then back-port it. Stay tuned! |
Updated PR. Removed duplicate Google Support JARs. |
Generated by 🚫 dangerJS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: PASS
JIRA:
https://jira.appcelerator.org/browse/TIMOB-26329
Test: