Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-26329] Android: Modified build to generate missing "R" classes for libraries added in 7.3.0 #10279

Merged
merged 2 commits into from Aug 23, 2018

Conversation

jquick-axway
Copy link
Contributor

JIRA:
https://jira.appcelerator.org/browse/TIMOB-26329

Test:

  1. Download "hyperloop-examples" project from here.
  2. Build and run on Android.
  3. Tap on the "Native Layout (XML)" row in the app.
  4. Verify that the app does not crash.

Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: PASS

But we should also remove the duplicate libs located in appcompat and add design and compat as dependencies of appcompat

@lokeshchdhry
Copy link
Contributor

FR Passed.

Ran the Hyperloop-example-master/Native Layout test & no exception is seen.

Studio Ver: 5.1.0.201808080937
SDK Ver: 7.5.0 local build
OS Ver: 10.13.5
Xcode Ver: Xcode 9.4.1
Appc NPM: 4.2.13
Appc CLI: 7.0.6-master.5
Daemon Ver: 1.1.3
Ti CLI Ver: 5.1.1
Alloy Ver: 1.13.2
Node Ver: 8.9.1
NPM Ver: 5.5.1
Java Ver: 10.0.2
Devices: ⇨ google Nexus 5 (Android 6.0.1)
⇨ google Nexus 6P (Android 8.1.0)

@lokeshchdhry
Copy link
Contributor

@jquick-axway , Are we done with this PR ? Also, can you please provide a 7.3.1 backport.

@jquick-axway
Copy link
Contributor Author

I just tested this on Windows and it works. I wanted to make sure that the command line wasn't too long.

@lokeshchdhry, thanks for testing this. I'm going to remove the redundant JAR files Gary found and then back-port it. Stay tuned!

@jquick-axway
Copy link
Contributor Author

Updated PR.

Removed duplicate Google Support JARs.

@build
Copy link
Contributor

build commented Aug 23, 2018

Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

Copy link
Contributor

@garymathews garymathews left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: PASS

@lokeshchdhry lokeshchdhry merged commit 05da959 into tidev:master Aug 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants