[TIMOB-26334] iOS: Fix some Ti.Media.AudioPlayer related bugs #10285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| var audioPlayer; | ||
|
|
||
| beforeEach(function () { | ||
| audioPlayer = Ti.Media.createAudioPlayer({ url: 'sample.mp3' }); |
There was a problem hiding this comment.
Can you change 'sample.mp3' to '/sample.mp3' please?
Android does not currently support loading APK asset directory files via relative paths yet until TIMOB-13642 has been fixed. Will avoid a unit test failure.
|
|
||
| // Re-set URL to test TIMOB-26334, this should not crash | ||
| try { | ||
| audioPlayer.url = 'sample.mp3'; |
There was a problem hiding this comment.
Same as above. Change to absolute path '/sample.mp3'.
…Fragment (tidev#10245) * Handle child-views added before the fragment transaction commit. * Fix formatting. * Override insertAt() and fix realizeViews for multiple views. * Ensure childred are removed from childrenToRealize on remove() call. * Fix formatting.
…oid differ in values by 5ms, so make ok within a 250 ms range for now
Tests:
Generated by 🚫 dangerJS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-26334