[TIMOB-26312]: iOS 12 Expose new NSUserActivity APIs for Siri Intents #10288
Conversation
Generated by 🚫 dangerJS |
|
|
||
| - (void)deleteSavedUserActivitiesForPersistentIdentifiers:(id)persistentIdentifiers | ||
| { | ||
| ENSURE_ARRAY(persistentIdentifiers); |
There was a problem hiding this comment.
Did you actually test all the new API's so far? Since this is a method, you need to unbox the persistentIdentifiers attribute with ENSURE_SINGLE_ARG(persistentIdentifiers, NSArray).
| - (void)setEligibleForPrediction:(NSNumber *)value | ||
| { | ||
| ENSURE_TYPE(value, NSNumber); | ||
| ENSURE_UI_THREAD(setEligibleForSearch, value); |
There was a problem hiding this comment.
The UI-thread should be validated before the type-checks.
| return NUMBOOL(NO); | ||
| } | ||
|
|
||
| return NUMBOOL(_userActivity.isEligibleForPrediction); |
There was a problem hiding this comment.
We should move all these to native Obj-C 2.0 statements, e.g. @(_userActivity.isEligibleForPrediction) and @(NO). But that should be done with an own PR and an own ticket. Maybe we can deprecate the old macros in SDK 8.0.0?.
| description: | | ||
| To donate a user activity to Siri Shortcuts, set eligibleForPrediction to 'true' and make the | ||
| user activity current. To make the user activity current, call the becomeCurrent method of activity. | ||
| For more information, see https://developer.apple.com/documentation/sirikit/donating_shortcuts?language=objc. |
There was a problem hiding this comment.
For more information, see [the Apple docs](https://developer.apple.com/documentation/sirikit/donating_shortcuts?language=objc).
| summary: | | ||
| A Boolean value that determines whether Siri can suggest the user activity as a shortcut to the user. | ||
| description: | | ||
| To donate a user activity to Siri Shortcuts, set eligibleForPrediction to 'true' and make the |
|
|
||
| #if IS_XCODE_10 | ||
|
|
||
| - (NSNumber *)eligibleForPrediction |
There was a problem hiding this comment.
Can you make sure all public API's are also in the interface header? It makes it easier to maintain.
| - (void)setEligibleForPrediction:(NSNumber *)value; | ||
| - (void)setPersistentIdentifier:(NSString *)value; | ||
| - (void)deleteSavedUserActivitiesForPersistentIdentifiers:(id)persistentIdentifiers; | ||
| - (void)deleteAllSavedUserActivities:(id)unused; |
There was a problem hiding this comment.
Not only the new methods but all methods ;-). Including code-docs and params-descriptions.
There was a problem hiding this comment.
All method exposing is fine. Do we use code-docs and params-description in header file in Titanium SDK?
There was a problem hiding this comment.
For Ti core-developers, it will help knowing which params are used in the "boxed" arguments. But it looks fine for now.
|
7_4_X version is #10292 |
https://jira.appcelerator.org/browse/TIMOB-26312