Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-26339] (7_3_X) iOS: Fix "scheduleLocalNotification" API from not repeating triggers properly #10290

Merged
merged 3 commits into from Aug 29, 2018
Merged

[TIMOB-26339] (7_3_X) iOS: Fix "scheduleLocalNotification" API from not repeating triggers properly #10290

merged 3 commits into from Aug 29, 2018

Conversation

hansemannn
Copy link
Collaborator

JIRA: https://jira.appcelerator.org/browse/TIMOB-26339

no tests because only testable via UI-tests.

@hansemannn
fix: scheduleLocalNotification API
442d972 
# Conflicts:
#	iphone/Classes/TiAppiOSProxy.m
@hansemannn hansemannn added this to the 7.3.1 milestone Aug 28, 2018
@build build added the ios label Aug 28, 2018
@build
Copy link
Contributor

build commented Aug 28, 2018 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

@build build added the docs label Aug 28, 2018
vijaysingh-axway
vijaysingh-axway approved these changes Aug 29, 2018
View reviewed changes
Copy link
Contributor

@vijaysingh-axway vijaysingh-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR passed.

@hansemannn hansemannn modified the milestones: 7.3.1, 7.3.2 Aug 29, 2018
@hansemannn hansemannn merged commit 955445d into tidev:7_3_X Aug 29, 2018
@hansemannn hansemannn modified the milestones: 7.3.2, 7.3.1 Aug 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vijaysingh-axway vijaysingh-axway vijaysingh-axway approved these changes

Assignees
No one assigned
Labels
docs ios no tests
Projects
None yet
Milestone
7.3.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hansemannn @build @vijaysingh-axway