Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-26344] (7_4_X) iOS: Pass blocks with copy to retain them properly #10297

Merged
merged 1 commit into from Sep 6, 2018
Merged

[TIMOB-26344] (7_4_X) iOS: Pass blocks with copy to retain them properly #10297

merged 1 commit into from Sep 6, 2018

Conversation

hansemannn
Copy link
Collaborator

JIRA: https://jira.appcelerator.org/browse/TIMOB-26344

no tests because of the low-level change inside the application-delegate that requires user-interaction (in this case by triggering shortcut-items from the home screen).

@hansemannn hansemannn added this to the 7.4.0 milestone Aug 30, 2018
@build
Copy link
Contributor

build commented Aug 30, 2018 •
edited

Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

vijaysingh-axway
vijaysingh-axway approved these changes Aug 31, 2018
View reviewed changes
Copy link
Contributor

@vijaysingh-axway vijaysingh-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR passed.

@sgtcoolguy sgtcoolguy merged commit 9b2dcd6 into tidev:7_4_X Sep 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vijaysingh-axway vijaysingh-axway vijaysingh-axway approved these changes

Assignees
No one assigned
Labels
bug in-qe-testing 🕵 ios no tests
Projects
None yet
Milestone
7.4.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hansemannn @build @vijaysingh-axway @sgtcoolguy