[TIMOB-26371] Ensure buildAssetsDir exists before writing app props file #10313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cb1kenobi
reviewed
Sep 10, 2018
iphone/cli/commands/_build.js
Outdated
| @@ -5819,6 +5819,8 @@ iOSBuilder.prototype.copyResources = function copyResources(next) { | |||
| const contents = JSON.stringify(props); | |||
| if (!fs.existsSync(appPropsFile) || contents !== fs.readFileSync(appPropsFile).toString()) { | |||
| this.logger.debug(__('Writing %s', appPropsFile.cyan)); | |||
|
|
|||
| fs.existsSync(this.buildAssetsDir) || wrench.mkdirSyncRecursive(this.buildAssetsDir); | |||
There was a problem hiding this comment.
Shouldn't you only do this if encryption is enabled?
if (this.encryptJS && fs.existsSync(this.buildAssetsDir)) {
wrench.mkdirSyncRecursive(this.buildAssetsDir);
}There was a problem hiding this comment.
Good point, I had missed that we're not always working with buildAssetsDir, and looking at the flow xcodeAppDir will exist before this so I'll edit to only do this when we're encrypting
cb1kenobi
approved these changes
Sep 10, 2018
ewanharris
force-pushed
the
TIMOB-26371
branch
from
19b850e
to
a75b4ce
Compare
Generated by 🚫 dangerJS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-26371
Due to the parallelisation of this processes the assets dir doesn't already exist. Just make sure it exists before we write it.