Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-26399] (7_4_X) iOS: Fix a couple of push-notifications related issues #10328

Merged
merged 4 commits into from Sep 20, 2018
Merged

[TIMOB-26399] (7_4_X) iOS: Fix a couple of push-notifications related issues #10328

merged 4 commits into from Sep 20, 2018

Conversation

miniman42
Copy link
Contributor

@miniman42 miniman42 commented Sep 19, 2018 •
edited by hansemannn

JIRA: https://jira.appcelerator.org/browse/TIMOB-26399

Fixes:

  • Remote Notification callback not being triggered when app in foreground
  • Remote Notification action responses not being handled
  • Notification response text not being parsed
  • Remote Notification action handling in the background
  • Duplicated silent push notifications

Fixes for:
2a1632b 
- Remote Notification callback not being triggered when app in foreground
- Remote Notification action responses not being handled
- Notification response text not being parsed
- Remote Notification action handling in the background
- Duplicated silent push notifications
@build
Copy link
Contributor

build commented Sep 19, 2018 •
edited

Messages
📖

🎉 Another contribution from our awesome community member, miniman42! Thanks again for helping us make Titanium SDK better. 👍
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

@hansemannn hansemannn self-requested a review September 19, 2018 18:24
@hansemannn hansemannn changed the base branch from 7_4_X to master September 19, 2018 18:25
@hansemannn hansemannn changed the base branch from master to 7_4_X September 19, 2018 18:25
@hansemannn hansemannn added this to the 7.4.1 milestone Sep 19, 2018
@hansemannn hansemannn changed the title AC-5899 Support for push notifications including background actions in ios 12 [TIMOB-26399] iOS: Fix a couple of push-notifications related issues Sep 19, 2018
@hansemannn hansemannn changed the title [TIMOB-26399] iOS: Fix a couple of push-notifications related issues [TIMOB-26399] (7_4_X) iOS: Fix a couple of push-notifications related issues Sep 20, 2018
hansemannn
hansemannn reviewed Sep 20, 2018
View reviewed changes
Copy link
Collaborator

@hansemannn hansemannn left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good!

hansemannn
hansemannn approved these changes Sep 20, 2018
View reviewed changes
Copy link
Collaborator

@hansemannn hansemannn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR approved! Merging once Jenkins is all green 🍀.

@hansemannn hansemannn merged commit 3d0fdd9 into tidev:7_4_X Sep 20, 2018
miniman42 pushed a commit to miniman42/titanium_mobile that referenced this pull request Sep 27, 2018
Merge commit 'ff0f00370512a5a463441a3c3f7ec0d9a9e25857' into 7_4_X_GB
c1e024c 
* commit 'ff0f00370512a5a463441a3c3f7ec0d9a9e25857':
  [TIMOB-26413] fix: use correct scale (tidev#10351)
  [TIMOB-26404] Update to hyperloop 3.1.3 (tidev#10333)
  [TIMOB-26399] (7_4_X) iOS: Fix a couple of push-notifications related issues (tidev#10328)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hansemannn hansemannn hansemannn approved these changes

Assignees
No one assigned
Labels
community 🔥 ios no tests
Projects
None yet
Milestone
7.4.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@miniman42 @build @hansemannn