Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-26399] iOS: Fix notification update to trigger correct callback for default notification action #10353

Merged
merged 4 commits into from Sep 28, 2018

Conversation

miniman42
Copy link
Contributor

JIRA: https://jira.appcelerator.org/browse/TIMOB-26399

Provide a clear PR title prefixed with [TICKET]

Optional Description:
Update to handle default notification action and trigger remotenotification callback instead of remotenotificationaction callback. Ensures completion block is called in an orderly fashion

Greg Balmer added 2 commits September 27, 2018 17:02
…remotenotification callback instead of remotenotificationaction callback. Ensures completion block is called in an orderly fashion
@build
Copy link
Contributor

build commented Sep 27, 2018

Messages
📖

🎉 Another contribution from our awesome community member, miniman42! Thanks again for helping us make Titanium SDK better. 👍

📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

@hansemannn hansemannn added this to the 7.5.0 milestone Sep 27, 2018
@hansemannn hansemannn changed the title TIMOB-26399 Notification fix update to trigger correct callback for default notification action [TIMOB-26399] iOS: Fix notification update to trigger correct callback for default notification action Sep 27, 2018
@sgtcoolguy sgtcoolguy merged commit ac34483 into tidev:master Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants