Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-26399] (7_4_X) iOS: Fix notification update to trigger correct callback for default notification action #10355

Merged
merged 4 commits into from Sep 27, 2018

Conversation

miniman42
Copy link
Contributor

…remotenotification callback instead of remotenotificationaction callback. Ensures completion block is called in an orderly fashion

JIRA: https://jira.appcelerator.org/browse/TIMOB-26399

Provide a clear PR title prefixed with [TICKET]

Optional Description:

…remotenotification callback instead of remotenotificationaction callback. Ensures completion block is called in an orderly fashion
@build
Copy link
Contributor

build commented Sep 27, 2018

Messages
📖

🎉 Another contribution from our awesome community member, miniman42! Thanks again for helping us make Titanium SDK better. 👍

📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

@hansemannn hansemannn added this to the 7.4.1 milestone Sep 27, 2018
@hansemannn hansemannn changed the title TIMOB-26399 Update to handle default notification action and trigger … [TIMOB-26399] (7_4_X) iOS: Fix notification update to trigger correct callback for default notification action Sep 27, 2018
@hansemannn hansemannn merged commit bbcfaa3 into tidev:7_4_X Sep 27, 2018
miniman42 pushed a commit to miniman42/titanium_mobile that referenced this pull request Sep 27, 2018
* 7_4_X:
  [TIMOB-26399] (7_4_X) iOS: Fix notification update to trigger correct callback for default notification action (tidev#10355)
  [TIMOB-26391] Protect js objects for proxies (tidev#10352)

# Conflicts:
#	iphone/Classes/TiApp.m
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants