[TIMOB-26425] Always use thread-safe access to timers array #10360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generated by 🚫 dangerJS |
vijaysingh-axway
suggested changes
Oct 2, 2018
There was a problem hiding this comment.
@janvennemann Your logic looks good to me. You need to adjust this PR a bit e.g declaration and definition of variable timerLock should be out of TI_USE_KROLL_THREAD macro.
Can you create PR for 7_4_X so we can ask reporter to test? Thanks!
|
Addressed the missing declarations and moved them out of the kroll macro. |
|
@sgtcoolguy Updated the PR and the Jenkins build is looking good now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-26425
Optional Description:
Timers are always started in their own thread. Locking should also be done when running on main thread to make the access to the timers array thread-safe.