Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-26403] Update node-titanium-sdk, pass logger to analyzeJs #10364

Merged
merged 1 commit into from Oct 3, 2018
Merged

[TIMOB-26403] Update node-titanium-sdk, pass logger to analyzeJs #10364

merged 1 commit into from Oct 3, 2018

Conversation

ewanharris
Copy link
Collaborator

JIRA: https://jira.appcelerator.org/browse/TIMOB-26403

  • Update node-titanium-sdk@0.6.4 to include fix
  • Pass logger into to analyzeJs so we can log deprecation warning

To test:

  1. Build kitchensink-v2 to device or simulator
  • You should see a warning log about "implicit global scope being deprecated
  • It should launch successfully

@sgtcoolguy sgtcoolguy mentioned this pull request Oct 3, 2018
Merged
@build
Copy link
Contributor

build commented Oct 3, 2018

Fails
🚫

Tests have failed, see below for more information.
Messages
📖

💾 Here's the generated SDK zipfile.

Tests:

Classname Name Time Error
android.Titanium.UI.TextField focus-blur-bubbles 6.377 Error: timeout of 5000ms exceeded

Generated by 🚫 dangerJS

@sgtcoolguy sgtcoolguy self-assigned this Oct 3, 2018
@sgtcoolguy
Copy link
Contributor

CR and FR pass!

@sgtcoolguy sgtcoolguy merged commit d61a4b9 into tidev:master Oct 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@sgtcoolguy sgtcoolguy

Labels
bug cli 📟 no tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ewanharris @build @sgtcoolguy