Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-26433] iOS: Fix xcode cleanup #10365

Merged
merged 2 commits into from Oct 4, 2018
Merged

[TIMOB-26433] iOS: Fix xcode cleanup #10365

merged 2 commits into from Oct 4, 2018

Conversation

garymathews
Copy link
Contributor

  • Do not cleanup with new build system if the new build system is not being used

JIRA Ticket

@garymathews garymathews mentioned this pull request Oct 3, 2018
Merged
@build
Copy link
Contributor

build commented Oct 3, 2018 •
edited

Fails
🚫

Tests have failed, see below for more information.
Messages
📖

💾 Here's the generated SDK zipfile.

Tests:

Classname Name Time Error
android.Titanium.UI.View getOrCreateView() should always return a View 10.068 Error: timeout of 10000ms exceeded

Generated by 🚫 dangerJS

vijaysingh-axway
vijaysingh-axway approved these changes Oct 4, 2018
View reviewed changes
Copy link
Contributor

@vijaysingh-axway vijaysingh-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR passed.

@sgtcoolguy sgtcoolguy added this to the 7.5.0 milestone Oct 4, 2018
@sgtcoolguy sgtcoolguy merged commit 7e6521e into tidev:master Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vijaysingh-axway vijaysingh-axway vijaysingh-axway approved these changes

Assignees
No one assigned
Labels
bug ios no tests
Projects
None yet
Milestone
7.5.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@garymathews @build @vijaysingh-axway @sgtcoolguy