New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIMOB-26435] Update gradle for JDK 11 support #10369
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CR: Pass
Thanks @ewanharris! :)
I'm okay with this... even though we're not technically building with "gradle" yet. We only use "gradle" to download the newest ProGuard, which is used to scan which Java classes are needed to be in the main dex file when multidexed. But it's a critical step that all app builds need to go through. |
@ewanharris for the error message, how about: "Generating main class list for the dexer failed" At least that's what the command is supposed to do, right? |
77fd3f2
to
9390bbd
Compare
FR Passed. Build to device, emulator works fine with JDK 11 from CLI. Also, packaging & module creation works fine as well. Studio Ver: 5.1.1.201809051655 |
Multidex tests passed on Android 4.X. |
Generated by 🚫 dangerJS |
JIRA: https://jira.appcelerator.org/browse/TIMOB-26435
JDK 11 Test:
Multidexing Test:
Run the test shown in TIMOB-25597, but use this PR's Titanium version. Verify that the app can launch successfully on an Android 4.x without crashing.