Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-26435] Update gradle for JDK 11 support #10369

Merged
merged 4 commits into from Oct 12, 2018

Conversation

ewanharris
Copy link
Collaborator

@ewanharris ewanharris commented Oct 4, 2018

JIRA: https://jira.appcelerator.org/browse/TIMOB-26435

  • Update to gradle 4.10.2
  • Use https to download gradle
  • Change "Failed to run dexer" warning to "Failed to run gradle"
    • We have (had) 3 potential error cases where we log "Failed to run dexer" so tracking down what went wrong is kind of a PITA
    • I'd like to reduce this to 1 "Failed to run dexer" error case, so if anyone has suggestions for this error log, send them in on a postcard 🙂 I think it's still the dexer step but can we make it a little more clear what the task is?

JDK 11 Test:

  1. Install JDK 11. (Note that this will currently break Appc Studio.)
  2. Build and run a Titanium app for Android.
  3. Verify that it builds and runs successfully.

Multidexing Test:
Run the test shown in TIMOB-25597, but use this PR's Titanium version. Verify that the app can launch successfully on an Android 4.x without crashing.

Copy link
Contributor

@jquick-axway jquick-axway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: Pass

Thanks @ewanharris! :)

@jquick-axway jquick-axway added this to the 7.5.0 milestone Oct 4, 2018
@jquick-axway
Copy link
Contributor

Change "Failed to run dexer" warning to "Failed to run gradle"

I'm okay with this... even though we're not technically building with "gradle" yet. We only use "gradle" to download the newest ProGuard, which is used to scan which Java classes are needed to be in the main dex file when multidexed. But it's a critical step that all app builds need to go through.

@janvennemann
Copy link
Contributor

@ewanharris for the error message, how about: "Generating main class list for the dexer failed" At least that's what the command is supposed to do, right?

@lokeshchdhry
Copy link
Contributor

FR Passed.

Build to device, emulator works fine with JDK 11 from CLI. Also, packaging & module creation works fine as well.

Studio Ver: 5.1.1.201809051655
SDK Ver: 7.5.0 local build
OS Ver: 10.13.5
Xcode Ver: Xcode 9.4.1
Appc NPM: 4.2.13
Appc CLI: 7.0.6
Daemon Ver: 1.1.3
Ti CLI Ver: 5.1.1
Alloy Ver: 1.13.2
Node Ver: 8.9.1
NPM Ver: 5.5.1
Java Ver: 11
Devices: ⇨ google Nexus 5 (Android 6.0.1)
⇨ google Nexus 6P (Android 8.1.0)
Emulator: ⇨ Android 4.1.2

@lokeshchdhry
Copy link
Contributor

lokeshchdhry commented Oct 8, 2018

Multidex tests passed on Android 4.X.

@build
Copy link
Contributor

build commented Oct 12, 2018

Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

@lokeshchdhry lokeshchdhry merged commit de830b7 into tidev:master Oct 12, 2018
@ewanharris ewanharris deleted the TIMOB-26435 branch October 15, 2018 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants