[TIMOB-26462] Improve error handling and logging when failing to connect to log server #10384
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cb1kenobi
requested changes
Oct 18, 2018
iphone/cli/commands/_build.js
Outdated
| } else { | ||
| _t.logger.error(__('Another process is currently bound to port %d', _t.tiLogServerPort)); | ||
| _t.logger.error(__('Set a unique <log-server-port> between 1024 and 65535 in the <ios> section of the tiapp.xml') + '\n'); | ||
| process.exit(1); |
There was a problem hiding this comment.
No need to duplicate process.exit(1). A single call outside the if block would suffice.
cb1kenobi
approved these changes
Oct 18, 2018
|
APPROVED |
ewanharris
force-pushed
the
TIMOB-26462
branch
from
0d04513
to
664364b
Compare
Generated by 🚫 dangerJS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-26462
Totally unsure of the verbiage, any comments on it are more than welcome.
Test steps
/etc/hostsfile to remote the localhost mapping