Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TIMOB-26477] Android: Fix Ti.Locale.setLanguage() #10391

Merged
merged 1 commit into from Oct 23, 2018
Merged

[TIMOB-26477] Android: Fix Ti.Locale.setLanguage() #10391

merged 1 commit into from Oct 23, 2018

Conversation

garymathews
Copy link
Contributor

  • Fix baseContext used by locale configuration

JIRA Ticket

@build
Copy link
Contributor

build commented Oct 22, 2018

Fails
🚫

🔬 There are library changes, but no changes to the unit tests. That's OK as long as you're refactoring existing code, but will require an admin to merge this PR. Please see README.md#unit-tests for docs on unit testing.
Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

@sgtcoolguy sgtcoolguy self-requested a review October 23, 2018 20:30
sgtcoolguy
sgtcoolguy approved these changes Oct 23, 2018
View reviewed changes
Copy link
Contributor

@sgtcoolguy sgtcoolguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR looks good to me

@sgtcoolguy sgtcoolguy merged commit 06851c4 into tidev:master Oct 23, 2018
@garymathews garymathews added this to the 7.5.0 milestone Oct 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgtcoolguy sgtcoolguy sgtcoolguy approved these changes

Assignees
No one assigned
Labels
android bug no tests
Projects
None yet
Milestone
7.5.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@garymathews @build @sgtcoolguy