Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-26382] Android: Revert "appc run" change #10396

Merged
merged 1 commit into from Oct 23, 2018

Conversation

jquick-axway
Copy link
Contributor

JIRA:
https://jira.appcelerator.org/browse/TIMOB-26382

Summary:
If the device was sitting on the home screen, then a menu would popup onscreen before the built app was ran. While this was harmless, it was bothering some app developers. We don't want this to turn into a tech-support issue, so, we're reverting it.

Test:

  1. Connect an Android device to your machine.
  2. Press the power button to turn off the screen (but don't power it off).
  3. Build and run a default Titanium classic app to that device.
  4. When the build/run completes, verify that the device's screen does not turn on anymore.
  5. Unlock the screen and verify that the built app was running in the background.

- If the device is sitting on the home screen, a menu will popup just before the built app is ran. Reverting this behavior.
  * This behavior was harmless, but it was bothering some app developers.
  * We don't want this to turn into a tech-support issue. Should find an alternative solution, such as via a plugin?
@sgtcoolguy
Copy link
Contributor

Looks like a straight revert of #10318, so I think we're good.

@sgtcoolguy sgtcoolguy merged commit 7166b36 into tidev:master Oct 23, 2018
@build
Copy link
Contributor

build commented Oct 23, 2018

Danger run resulted in 2 messages; to find out more, see the checks page.

Generated by 🚫 dangerJS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants