[TIMOB-26196] : Added more macros to make method available #10398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssjsamir
approved these changes
Oct 24, 2018
There was a problem hiding this comment.
FR Passed
Test Steps
- Created a Titanium build with this PR
- Created a Titanium project
- Added the test case from
https://gist.github.com/hansemannn/1414ea2d11238d1ce99d0528cc4d0cc7 - Able to see the following output
Average mic-power: -40.822940826416016
[INFO] : Peak mic-power: -29.065549850463867
[INFO] : Average mic-power: -31.644926071166992
[INFO] : Peak mic-power: -21.73211097717285
[INFO] : Average mic-power: -47.487144470214844
[INFO] : Peak mic-power: -25.6330623626709
[INFO] : Average mic-power: -48.85952377319336
[INFO] : Peak mic-power: -31.107315063476562
Test Environment
APPC Studio: 5.1.0.201808080937
iPhone 6 Sim (iOS 12)
APPC CLI: 7.0.6
Operating System Name: Mac OS Mojave
Operating System Version: 10.14
Node.js Version: 8.9.1
Xcode 10.0
Awaiting CR
Generated by 🚫 dangerJS |
janvennemann
approved these changes
Oct 25, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.appcelerator.org/browse/TIMOB-26196