Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIMOB-26453] Android: default value of borderWidth of view is not respected, if borderRadius is set (but no borderColor) #10402

Merged
merged 4 commits into from Nov 29, 2018

Conversation

ypbnv
Copy link
Contributor

@ypbnv ypbnv commented Oct 26, 2018

JIRA: https://jira.appcelerator.org/browse/TIMOB-26453

Description:
Default border width of 1 should be used only if we have a borderColor set.

Test case:
app.js

var win = Titanium.UI.createWindow({
height: Titanium.UI.FILL,
width: Titanium.UI.FILL,
layout: 'vertical',
backgroundColor: '#FFFFFF'
});
 
var view1 = Titanium.UI.createView({
top: 20,
height: 100,
width: 280,
backgroundColor: '#000000'
// No borderRadius
});
view1.add(Titanium.UI.createLabel({
color: '#FF0000',
text: 'Click here to test!'
}));
view1.addEventListener('click', function() {
view1.setBackgroundColor('#00FFFF');
});
 
var view2 = Titanium.UI.createView({
top: 20,
height: 100,
width: 280,
backgroundColor: '#000000',
borderRadius: 5
});
view2.add(Titanium.UI.createLabel({
color: '#FF0000',
text: 'Click here to test!'
}));
view2.addEventListener('click', function() {
view2.setBackgroundColor('#00FFFF');
});
 
win.add(view1);
win.add(view2);
 
win.open();

Before this PR the second view will have a visible border with width of one.

@build
Copy link
Contributor

build commented Oct 26, 2018

Messages
📖

💾 Here's the generated SDK zipfile.

Generated by 🚫 dangerJS

@keerthi1032
Copy link
Contributor

FR Passed. Waiting for CR to merge.

Test Environment:
Name = Mac OS X
Version = 10.13.6
Architecture = 64bit
Memory = 17179869184
Node.js
Node.js Version = 8.12.0
npm Version = 6.4.1
Titanium CLI
CLI Version = 5.1.1
Titanium SDK
SDK Version = local 8.0.0 sdk
Device =Samsung s5 Android 6,Pixel 2 Android 9
Emulator =Nexus Android 4.4, Pixel 2XL android 8

@build build requested a review from a team November 29, 2018 13:07
Copy link
Contributor

@sgtcoolguy sgtcoolguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sgtcoolguy sgtcoolguy merged commit 6736e58 into tidev:master Nov 29, 2018
build pushed a commit to hansemannn/titanium_mobile that referenced this pull request Dec 3, 2018
…fined (tidev#10402)

Default border width of 1 should be used only if we have a borderColor set.

Fixes TIMOB-26453
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants