[7_5_X][TIMOB-26499]: Remove namespace restriction in item templates #10410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolves TIMOB-26499
garymathews
reviewed
Oct 30, 2018
| DebugLog(@"[DEBUG] Failed to load native class %@, trying Alloy widget / CommonJS module", viewTemplate.type); | ||
| NSString *code = [NSString stringWithFormat:@"var result;" | ||
| "try {" | ||
| " var jsModule = require('/alloy/widgets/%@/controllers/widget');" |
There was a problem hiding this comment.
Unrelated, but should this be either:
require('./alloy/widgets/%@/controllers/widget');
require('alloy/widgets/%@/controllers/widget');
There was a problem hiding this comment.
I don't think it should. The first is a relative URL, the second is a legacy-style path that we should eventually not support (as it was treated as either relative or absolute, and I think differed by platform as to which is tried first).
The alloy directory should be a to-level dir under the app's Resources, so the absolute path should be correct to load it.
garymathews
changed the title
garymathews
approved these changes
Oct 30, 2018
infosia
reviewed
Nov 6, 2018
| "try {" | ||
| " var jsModule = require('/alloy/widgets/%@/controllers/widget');" | ||
| " if (!jsModule) {" | ||
| " jsModule = require('%@');" |
There was a problem hiding this comment.
As far as I can see, require throws JS exception instead of returning null nor undefined (tested on iOS emulator). So I think requiring wrong Alloy widget never fallback to CommonJS module here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.appcelerator.org/browse/TIMOB-26499
Removes the restriction for only
TiorTitaniumas a namespace to allow third-party modules again in list view item templates.Tries to construct the class first, catches the exception that is thrown if the class does not exists and only then falls back to the commonjs module loading.
fixes regression introduced in #10131